Commit ba0b367e authored by Hakim El Hattab's avatar Hakim El Hattab
Browse files

remove nuking of hash changes when hash is disabled

parent 772fa030
This diff is collapsed.
This diff is collapsed.
......@@ -131,12 +131,16 @@ export default class Location {
else if( config.hash ) {
window.history.replaceState( null, null, '#' + this.getHash() );
}
// UPDATE: The below nuking of all hash changes breaks
// anchors on pages where reveal.js is running. Removed
// in 4.0. Why was it here in the first place? ¯\_(ツ)_/¯
//
// If history and hash are both disabled, a hash may still
// be added to the URL by clicking on a href with a hash
// target. Counter this by always removing the hash.
else {
window.history.replaceState( null, null, window.location.pathname + window.location.search );
}
// else {
// window.history.replaceState( null, null, window.location.pathname + window.location.search );
// }
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment