Commit ddbe06eb authored by Hakim El Hattab's avatar Hakim El Hattab
Browse files

adjustments to reveal.js initialization flow

parent 9336fc11
......@@ -410,13 +410,6 @@ Reveal.addEventListener( 'customevent', function() {
<script type="module">
// WIP support for multiple reveal.js instances
// window.a = new Reveal(document.querySelector( '.reveal' ), {controls: false});
// a.initialize();
// window.b = new Reveal(document.querySelector( '.reveal' ), {controls: true});
// b.initialize();
// console.log(a.getConfig().controls,b.getConfig().controls);
// More info https://github.com/hakimel/reveal.js#configuration
Reveal.initialize({
controls: true,
......@@ -439,5 +432,22 @@ Reveal.addEventListener( 'customevent', function() {
</script>
<!--
<script type="module">
// WIP support for multiple reveal.js instances
import Reveal from '/js/reveal.js'
window.a = new Reveal(document.querySelector( '.reveal' ), {controls: false});
a.initialize();
window.b = new Reveal(document.querySelector( '.reveal' ), {controls: true});
b.initialize();
console.log(a.getConfig().controls,b.getConfig().controls);
</script>
-->
</body>
</html>
This diff is collapsed.
import Presentation from './reveal.js'
// The Reveal class can be instantiated to run multiple
// presentations on the same page
//
// let rvl = new Reveal( <HTMLElement>, { controls: false } )
// rvl.initialize()
// rvl.slide(2)
window.Reveal = Presentation;
// Simplified way to create a reveal.js instance on
// a page with only one presentation, makes us backwards
// compatible with reveal.js pre 4.0
// Provides a backwards compatible way to initialize
// reveal.js when there is only one presentation on
// the page.
//
// Reveal.initialize({ controls: false })
// Revea.slide(2)
window.Reveal.initialize = options => {
window.Reveal = new Presentation( document.querySelector( '.reveal' ), options );
window.Reveal.initialize();
return new Promise( resolve => window.Reveal.addEventListener( 'ready', resolve ) );
// Reveal.slide(2)
window.Reveal = {
initialize: options => {
window.Reveal = new Presentation( document.querySelector( '.reveal' ), options );
return window.Reveal.initialize();
}
}
\ No newline at end of file
......@@ -153,7 +153,7 @@ export default function( revealElement, options ) {
// Load plugins then move on to #start()
plugins.load( config.dependencies ).then( start )
return Reveal;
return new Promise( resolve => Reveal.addEventListener( 'ready', resolve ) );
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment